mapleFU commented on code in PR #35825:
URL: https://github.com/apache/arrow/pull/35825#discussion_r1235282235
##########
cpp/src/parquet/encoding.cc:
##########
@@ -1580,10 +1660,19 @@ class DictDecoderImpl : public DecoderImpl, virtual
public DictDecoder<Type> {
if (num_values != idx_decoder_.GetBatch(indices_buffer, num_values)) {
ParquetException::EofException();
}
- auto binary_builder =
checked_cast<::arrow::BinaryDictionary32Builder*>(builder);
- PARQUET_THROW_NOT_OK(binary_builder->AppendIndices(indices_buffer,
num_values));
- num_values_ -= num_values;
- return num_values;
+
+ // It looks like this method is only called by ByteArray types. Previously,
Review Comment:
No need, just ignore it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
