westonpace commented on a change in pull request #8680:
URL: https://github.com/apache/arrow/pull/8680#discussion_r544781710
##########
File path: cpp/src/arrow/util/future.cc
##########
@@ -243,6 +253,12 @@ class ConcreteFutureImpl : public FutureImpl {
}
}
cv_.notify_all();
+
+ // run callbacks
+ for (auto&& callback : callbacks_) {
Review comment:
I agree with Ben. The vector cannot be mutated because we know by the
time we reach the iteration that the future has (safely) been marked finished.
Any `AddCallback` from another thread will not modify the callbacks vector. I
added FutureTest::StressCallback to confirm.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
