zeroshade commented on code in PR #36009:
URL: https://github.com/apache/arrow/pull/36009#discussion_r1235535699
##########
go/arrow/flight/flightsql/server.go:
##########
@@ -640,7 +668,17 @@ type Server interface {
// EndTransaction commits or rollsback a transaction
EndTransaction(context.Context, ActionEndTransactionRequest) error
// CancelQuery attempts to explicitly cancel a query
+ // Deprecated: Since 13.0.0. If you can require all clients
+ // use 13.0.0 or later, you can use only CancelFlightInfo and
+ // you don't need to use CancelQuery. Otherwise, you may need
+ // to use CancelQuery and/or CancelFlightInfo.
Review Comment:
Having `flightSqlServer` have its own implementation of `CancelQuery` as I
mentioned above also has the nice effect here of allowing users to switch
entirely to `CancelFlightInfo` safely regardless of the client as the server
will do the right thing then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
