alamb commented on code in PR #6708:
URL: https://github.com/apache/arrow-datafusion/pull/6708#discussion_r1235539286
##########
datafusion/expr/src/expr.rs:
##########
@@ -869,53 +869,56 @@ impl Expr {
}
}
-/// Format expressions for display as part of a logical plan. In many cases,
this will produce
-/// similar output to `Expr.name()` except that column names will be prefixed
with '#'.
-impl fmt::Display for Expr {
- fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {
- write!(f, "{self:?}")
- }
+#[macro_export]
Review Comment:
Given how common this functionality is I wonder if we could move this macro
(or maybe make a function as I don't see any benefit in making it a macro) in
`datafusion_util` and use it more around the codebase.
Just a thought
##########
datafusion/expr/src/expr.rs:
##########
@@ -79,7 +79,7 @@ use std::sync::Arc;
/// assert_eq!(binary_expr.op, Operator::Eq);
/// }
/// ```
-#[derive(Clone, PartialEq, Eq, Hash)]
+#[derive(Clone, PartialEq, Eq, Hash, Debug)]
Review Comment:
❤️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
