wgtmac commented on code in PR #35825: URL: https://github.com/apache/arrow/pull/35825#discussion_r1236206598
########## cpp/src/parquet/arrow/arrow_reader_writer_test.cc: ########## @@ -1342,6 +1360,31 @@ TEST_F(TestUInt32ParquetIO, Parquet_1_0_Compatibility) { using TestStringParquetIO = TestParquetIO<::arrow::StringType>; +TEST_F(TestStringParquetIO, Basics) { Review Comment: Sorry for the confusion! Though simple string type won't cause any issue even before this change, it would be good to add this case to make sure large variant can read it. So let's not remove it. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org