wgtmac commented on code in PR #35886:
URL: https://github.com/apache/arrow/pull/35886#discussion_r1236236957
##########
cpp/src/parquet/properties.h:
##########
@@ -190,7 +193,14 @@ class PARQUET_EXPORT ColumnProperties {
size_t max_statistics_size() const { return max_stats_size_; }
- int compression_level() const { return compression_level_; }
+ int compression_level() const { return codec_options_->compression_level_; }
+
+ const std::shared_ptr<CodecOptions>& codec_options() const {
+ if (!codec_options_) {
+ return std::make_shared<CodecOptions>();
Review Comment:
This is a problem:
```
C:\projects\arrow\cpp\src\parquet\properties.h(200) : error C2220: the
following warning is treated as an error
C:\projects\arrow\cpp\src\parquet\properties.h(200) : warning C4172:
returning address of local variable or temporary
ninja: build stopped: subcommand failed.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
