metesynnada commented on code in PR #6724:
URL: https://github.com/apache/arrow-datafusion/pull/6724#discussion_r1236479691
##########
datafusion/core/src/physical_plan/joins/hash_join.rs:
##########
@@ -1097,6 +1098,49 @@ pub fn equal_rows(
err.unwrap_or(Ok(res))
}
+fn eq_dyn_null(
+ left: &dyn Array,
+ right: &dyn Array,
+ null_equals_null: bool,
+) -> Result<BooleanArray, ArrowError> {
+ match (left.data_type(), right.data_type()) {
+ (DataType::Null, DataType::Null) => Ok(BooleanArray::new(
+ BooleanBuffer::collect_bool(left.len(), |_| null_equals_null),
+ None,
+ )),
+ _ => eq_dyn(left, right),
+ }
+}
+
+pub fn equal_rows_arr(
+ indices_left: UInt64Array,
+ indices_right: UInt32Array,
+ left_arrays: &[ArrayRef],
+ right_arrays: &[ArrayRef],
+ null_equals_null: bool,
Review Comment:
In addition, we do not need to take ownership of `indices_left` and
`indices_right`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
