arthurpassos commented on code in PR #35825:
URL: https://github.com/apache/arrow/pull/35825#discussion_r1236885298
##########
cpp/src/parquet/arrow/arrow_reader_writer_test.cc:
##########
@@ -610,9 +615,14 @@ class ParquetIOTestBase : public ::testing::Test {
}
void ReaderFromSink(std::unique_ptr<FileReader>* out) {
+ return ReaderFromSink(out, default_arrow_reader_properties());
+ }
+
+ void ReaderFromSink(std::unique_ptr<FileReader>* out,
+ const ArrowReaderProperties& arrow_reader_properties) {
ASSERT_OK_AND_ASSIGN(auto buffer, sink_->Finish());
ASSERT_OK_NO_THROW(OpenFile(std::make_shared<BufferReader>(buffer),
- ::arrow::default_memory_pool(), out));
+ ::arrow::default_memory_pool(),
arrow_reader_properties, out));
Review Comment:
I am so sorry, I made the modifications locally and marked it as resolved,
but forgot to upload them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
