pitrou commented on code in PR #35989:
URL: https://github.com/apache/arrow/pull/35989#discussion_r1237059751
##########
cpp/src/parquet/statistics.h:
##########
@@ -166,13 +167,13 @@ class PARQUET_EXPORT EncodedStatistics {
void set_is_signed(bool is_signed) { is_signed_ = is_signed; }
EncodedStatistics& set_max(const std::string& value) {
- *max_ = value;
+ max_ = value;
Review Comment:
If you want to further micro-optimize:
```c++
EncodedStatistics& set_max(std::string value) {
max_ = std::move(value);
has_max = true;
return *this;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
