thisisnic commented on code in PR #35543:
URL: https://github.com/apache/arrow/pull/35543#discussion_r1237249856
##########
r/R/schema.R:
##########
@@ -244,10 +230,59 @@ print_schema_fields <- function(s) {
paste(map_chr(s$fields, ~ .$ToString()), collapse = "\n")
}
-#' @param ... [fields][field] or field name/[data type][data-type] pairs
+#' Schemas
+#'
+#' Create a schema or extract one from an object.
+#'
+#' @seealso [Schema] for detailed documentation of the Schema R6 object
+#' @param ... [fields][field], field name/[data type][data-type] pairs, or
object from which to extract a schema
+#' @examples
+#' # Create schema using pairs of field names and data types
+#' schema(a = int32(), b = float64())
+#'
+#' # Create schema using fields
+#' schema(
+#' field("b", double()),
+#' field("c", bool(), nullable = FALSE),
+#' field("d", string())
+#' )
+#'
+#' # Extract schemas from objects
+#' df <- data.frame(col1 = 2:4, col2 = c(0.1, 0.3, 0.5))
+#' tab1 <- arrow_table(df)
+#' schema(tab1)
+#' tab2 <- arrow_table(df, schema = schema(col1 = int8(), col2 = float32()))
+#' schema(tab2)
+#' @export
+schema <- function(...) {
+ dots <- list2(...)
+
+ if (length(dots) == 1 && !is.list(dots[[1]]) && is.null(names(dots)) &&
!inherits(dots[[1]], "Field")) {
+ return(infer_schema(dots[[1]]))
+ }
+
+ Schema$create(...)
Review Comment:
If the usage elsewhere is like this then I'm happy to change it here. You
didn't say that in your previous feedback. I don't really care what we do here
given it doesn't actually matter in any meaningful way. I will update it to
your suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
