zeroshade commented on code in PR #36009:
URL: https://github.com/apache/arrow/pull/36009#discussion_r1237281980
##########
go/arrow/flight/flightsql/server.go:
##########
@@ -511,8 +511,36 @@ func (BaseServer) BeginSavepoint(context.Context,
ActionBeginSavepointRequest) (
return nil, status.Error(codes.Unimplemented, "BeginSavepoint not
implemented")
}
-func (BaseServer) CancelQuery(context.Context, ActionCancelQueryRequest)
(CancelResult, error) {
- return CancelResultUnspecified, status.Error(codes.Unimplemented,
"CancelQuery not implemented")
+func (b *BaseServer) CancelQuery(context context.Context, request
ActionCancelQueryRequest) (CancelResult, error) {
+ result, err := b.CancelFlightInfo(context, request.GetInfo())
+ if err != nil {
+ return CancelResultUnspecified, err
+ }
Review Comment:
So what we could do is check whether or not the server they passed has a
`CancelQuery` method, and if it does then we dispatch to that. Otherwise,
default to calling `CancelFlightInfo`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
