westonpace opened a new pull request, #36206:
URL: https://github.com/apache/arrow/pull/36206

   ### Rationale for this change
   
   The acero & datasets tests rely on some common sources.  The current build 
includes those in every test executable as sources.  This was a bit of a change 
introduced as we extracted acero into its own library.  This causes those files 
to be built again and again and this caused an increase in build times.
   
   This change creates test libraries for each of those modules.  These test 
libraries include the common sources and are built once.  These libraries can 
then be included in the tests.  This avoids the duplicate builds.
   
   ### What changes are included in this PR?
   
   Changes to how common test sources are built and linked.
   
   ### Are these changes tested?
   
   Yes.  These tests still run as part of the unit tests.
   
   I'm not entirely sure if the cmake.in and pc.in files are tested or not as I 
don't know entirely how they factor into things.  However, I believe these are 
only needed if users want to rely on these test libraries and I'm not sure how 
critical that is.
   
   ### Are there any user-facing changes?
   
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to