zeroshade commented on issue #36186: URL: https://github.com/apache/arrow/issues/36186#issuecomment-1601630785
The only problem I can see with this idea is that there's no way for your accounting to attribute the allocated memory to a specific array or record at allocation time. For example if there are multiple goroutines active and handling building multiple arrays or records, that information isn't passed down to the allocator unless you're manually doing it in your own code in your interactions with the allocator. Which, in that case, you could just check it and throw an error at that point? That said, I'm not opposed to this change to the interface (although it will result in a very large PR to change everywhere we call Allocate to handle an error and propagate it). Though, this might cause consumers who have their own custom allocators to break which I'd be concerned for. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
