kou commented on PR #36191: URL: https://github.com/apache/arrow/pull/36191#issuecomment-1601703782
Could you fix a lint failure? https://github.com/apache/arrow/actions/runs/5334518109/jobs/9670310791?pr=36191#step:5:926 ```text FAILED: CMakeFiles/check-format cd /tmp/arrow-lint-89g59kh1/cpp-build && /usr/local/bin/python /arrow/cpp/build-support/run_clang_format.py --clang_format_binary /usr/bin/clang-format-14 --exclude_globs /arrow/cpp/build-support/lint_exclusions.txt --source_dir /arrow/cpp/src --source_dir /arrow/cpp/examples --source_dir /arrow/cpp/tools --quiet --- /arrow/cpp/src/parquet/stream_reader_test.cc +++ /arrow/cpp/src/parquet/stream_reader_test.cc (after clang format) @@ -984,13 +984,13 @@ int nrows = 0; for (auto group = 0; group < num_row_groups; ++group) { - for (auto i = 0; i < num_rows_per_group; ++i) { - os << static_cast<uint16_t>(group); - os << static_cast<uint64_t>(nrows); - os << EndRow; - nrows++; - } - os.EndRowGroup(); + for (auto i = 0; i < num_rows_per_group; ++i) { + os << static_cast<uint16_t>(group); + os << static_cast<uint64_t>(nrows); + os << EndRow; + nrows++; + } + os.EndRowGroup(); } } @@ -1013,7 +1013,7 @@ uint16_t current_row_group = 0; uint64_t current_global_row = 0; reader_ >> current_row_group; - EXPECT_EQ(current_row_group, current_row/10); + EXPECT_EQ(current_row_group, current_row / 10); reader_ >> current_global_row; EXPECT_EQ(current_global_row, current_row); @@ -1026,7 +1026,7 @@ // we read row 33 (were at 34, then skipped 4 => 38) current_row = 38; reader_ >> current_row_group; - EXPECT_EQ(current_row_group, current_row/10); + EXPECT_EQ(current_row_group, current_row / 10); reader_ >> current_global_row; EXPECT_EQ(current_global_row, current_row); @@ -1050,7 +1050,6 @@ ASSERT_GE(retval, 0); EXPECT_TRUE(reader_.eof()); - } } // namespace test /arrow/cpp/src/parquet/stream_reader_test.cc had clang-format style issues ``` You can fix it by `ninja format`/`make format` or something. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
