kou commented on code in PR #36009:
URL: https://github.com/apache/arrow/pull/36009#discussion_r1238088931
##########
go/arrow/flight/flightsql/server.go:
##########
@@ -511,8 +511,36 @@ func (BaseServer) BeginSavepoint(context.Context,
ActionBeginSavepointRequest) (
return nil, status.Error(codes.Unimplemented, "BeginSavepoint not
implemented")
}
-func (BaseServer) CancelQuery(context.Context, ActionCancelQueryRequest)
(CancelResult, error) {
- return CancelResultUnspecified, status.Error(codes.Unimplemented,
"CancelQuery not implemented")
+func (b *BaseServer) CancelQuery(context context.Context, request
ActionCancelQueryRequest) (CancelResult, error) {
+ result, err := b.CancelFlightInfo(context, request.GetInfo())
+ if err != nil {
+ return CancelResultUnspecified, err
+ }
Review Comment:
You mean that we keep backward compatibility for users who are using
`CancelQuery`, right?
If so, could you push a code for it to this branch? I don't know much about
`reflect` package in Go...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
