rtpsw commented on PR #36094: URL: https://github.com/apache/arrow/pull/36094#issuecomment-1602442838
> This makes sense to me. Let me verify I understand: > > Before, on InputReceived, we would update the memo for an input based on the new batch. > > Now, the only thing that really happens on InputReceived, is the batch is placed into the appropriate input queue. The update to the memo table happens when teh processing thread runs, as it is processing batches for an input. As @icexelloss said, this is correct. However, there is another difference to note. The pre-PR code invalidates the key hasher and updates the memo-store time given any batch, whereas the post-PR code does so given all but the first batch (after `batches_processed_` is incremented). This is fine because the key hasher is initialized as invalid and the memo-store time is initialized to the lowest value. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
