alamb commented on code in PR #4441:
URL: https://github.com/apache/arrow-rs/pull/4441#discussion_r1238631719
##########
parquet/Cargo.toml:
##########
@@ -64,8 +64,9 @@ seq-macro = { version = "0.3", default-features = false }
futures = { version = "0.3", default-features = false, features = ["std"],
optional = true }
tokio = { version = "1.0", optional = true, default-features = false, features
= ["macros", "rt", "io-util"] }
hashbrown = { version = "0.14", default-features = false }
-twox-hash = { version = "1.6", default-features = false }
+xxhash-rust = { version = "0.8", features = ["xxh64"] }
paste = { version = "1.0" }
+sbbf-rs-safe = "0.2"
Review Comment:
Rather than using a new crate (that would add a new dependency and need to
be maintained, etc) what do you think about inlining your implementation into
this repository?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
