mapleFU commented on PR #35989:
URL: https://github.com/apache/arrow/pull/35989#issuecomment-1602983417
Emmm I've tried it, I think `metadata.__isset.statistics &&
!metadata.statistics.__isset.null_count` might means it has null but not set
it's count. We use `metadata.num_values - metadata.statistics.null_count` to
get `num_values` in `Statistics` (`num_values` is just used to build page index
)
If all writer can make sure that `metadata.__isset.statistics &&
!metadata.statistics.__isset.null_count` means no nulls, the currently
implemention is right. If we regard `num_values` in `Statistics` as
"wrongable", it's also ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
