jackwener commented on code in PR #4442:
URL: https://github.com/apache/arrow-rs/pull/4442#discussion_r1238880350
##########
arrow-string/src/substring.rs:
##########
@@ -246,36 +247,59 @@ fn get_start_end_offset(
(start_offset, end_offset)
}
-fn binary_substring<OffsetSize: OffsetSizeTrait>(
- array: &GenericBinaryArray<OffsetSize>,
- start: OffsetSize,
- length: Option<OffsetSize>,
-) -> Result<ArrayRef, ArrowError> {
+fn byte_substring<T: ByteArrayType>(
+ array: &GenericByteArray<T>,
+ start: T::Offset,
+ length: Option<T::Offset>,
+) -> Result<ArrayRef, ArrowError>
+where
+ <T as ByteArrayType>::Native: PartialEq,
+{
let offsets = array.value_offsets();
let data = array.value_data();
- let zero = OffsetSize::zero();
+ let zero = <T::Offset as Zero>::zero();
+
+ // Check if `offset` is at a valid char boundary.
Review Comment:
Thanks for @alamb review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
