icexelloss commented on PR #36253: URL: https://github.com/apache/arrow/pull/36253#issuecomment-1603311058
@westonpace I would like a request a review on this PR. The code should be relatively straight forward and similar to https://github.com/apache/arrow/pull/35514 so hopefully no confusion/surprises here. For the implementation of the grouping, I used an approach similar to `GroupedListImpl` aggregator and `partition.cc` For the registration, I decided to register both scalar/hash kernel with one API `register_aggregate_function` because I think scalar/hash difference is not really something user should be worry about (from user's point of view, it is just "aggregation", whether it is hash/scalar is an compute implementation detail). Let me know if those sounds OK to you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
