danepitkin commented on code in PR #36162:
URL: https://github.com/apache/arrow/pull/36162#discussion_r1239031012
##########
python/pyarrow/src/arrow/python/inference.cc:
##########
@@ -560,6 +573,17 @@ class TypeInferrer {
return Status::OK();
}
+ Status VisitArrowScalar(PyObject* obj, bool* keep_going) {
Review Comment:
I think we can add an `/* unused */` comment for `keep_going` since we do
want to check all values.
##########
python/pyarrow/tests/test_convert_builtin.py:
##########
@@ -2363,3 +2363,136 @@ def test_array_from_pylist_offset_overflow():
assert isinstance(arr, pa.ChunkedArray)
assert len(arr) == 2**31
assert len(arr.chunks) > 1
+
+
Review Comment:
Great test cases! I see we aren't testing all scalar types defined in
https://arrow.apache.org/docs/python/api/datatypes.html, but I don't think we
need to since many of them take identical code paths, right? e.g. date32 vs
date64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
