kevingurney commented on code in PR #36273: URL: https://github.com/apache/arrow/pull/36273#discussion_r1240348584
########## matlab/src/cpp/arrow/matlab/error/error.h: ########## @@ -17,19 +17,154 @@ #pragma once - #include "arrow/status.h" #include "libmexclass/error/Error.h" -#include <string_view> - +// +// MATLAB_ERROR_IF_NOT_OK(expr, id) +// +// --- Description --- +// +// A macro used to return an error to MATLAB if the arrow::Status returned +// by the specified expression is not "OK" (i.e. error). +// +// **NOTE**: This macro should be used inside of the static make() member function for a +// Proxy class. Use MATLAB_ERROR_IF_NOT_OK_WITH_CONTEXT inside of a non-static +// Proxy member function. +// +// --- Arguments --- +// +// lhs - variable name to assign to (e.g. auto array) Review Comment: Thanks for catching this! I think I had named the input argument `lhs` originally and then renamed it and forgot to remove this line. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
