WillAyd commented on code in PR #844:
URL: https://github.com/apache/arrow-adbc/pull/844#discussion_r1240442781
##########
c/cmake_modules/AdbcDefines.cmake:
##########
@@ -60,16 +60,40 @@ if(CXX_LINKER_SUPPORTS_VERSION_SCRIPT)
endif()
# Set common build options
-macro(adbc_configure_target TARGET)
- if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
- target_compile_options(${TARGET}
- PRIVATE -Wall
- -Werror
- -Wextra
- -Wpedantic
- -Wno-unused-parameter
- -Wunused-result)
+if(NOT ADBC_BUILD_WARNING_LEVEL OR ADBC_BUILD_WARNING_LEVEL STREQUAL "")
+ if("${CMAKE_BUILD_TYPE}" STREQUAL "RELEASE")
+ set(ADBC_BUILD_WARNING_LEVEL "PRODUCTION")
+ else()
+ set(ADBC_BUILD_WARNING_LEVEL "CHECKIN")
+ endif()
+endif()
+
+set(ADBC_C_CXX_FLAGS)
+if("${ADBC_BUILD_WARNING_LEVEL}" STREQUAL "CHECKIN")
+ if(MSVC)
+ set(ADBC_C_CXX_FLAGS /Wall /WX)
Review Comment:
Most of the warnings are coming from the vendored nanoarrow which doesn't
build with warnings on MSVC. A lot of the case statement warnings are easy
enough to fix but will be hard to warn on MSVC downstream if also not set up in
nanoarrow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
