kou commented on code in PR #846:
URL: https://github.com/apache/arrow-adbc/pull/846#discussion_r1240625668
##########
c/cmake_modules/GoUtils.cmake:
##########
@@ -204,6 +204,9 @@ function(add_go_lib GO_MOD_DIR GO_LIBNAME)
endif()
if(NOT WIN32)
install(FILES "${LIBOUT_SHARED}" "${LIBOUT_SHARED}.${ADBC_SO_VERSION}"
TYPE LIB)
+ else()
+ # This symlink doesn't get installed
+ install(FILES "${LIBOUT_SHARED}.${ADBC_SO_VERSION}" TYPE BIN)
Review Comment:
We may want to invert this condition for readability:
```suggestion
if(WIN32)
# This symlink doesn't get installed
install(FILES "${LIBOUT_SHARED}.${ADBC_SO_VERSION}" TYPE BIN)
else()
install(FILES "${LIBOUT_SHARED}" "${LIBOUT_SHARED}.${ADBC_SO_VERSION}"
TYPE LIB)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
