lidavidm commented on code in PR #34817:
URL: https://github.com/apache/arrow/pull/34817#discussion_r1240887616
##########
cpp/src/arrow/flight/types.h:
##########
@@ -409,6 +409,15 @@ struct ARROW_FLIGHT_EXPORT Location {
/// \brief Get the scheme of this URI.
std::string scheme() const;
+ /// \brief Get the path of this URI.
+ std::string path() const;
+
+ /// \brief Get the query parameters of this URI.
+ arrow::Result<std::vector<std::pair<std::string, std::string>>> QueryItems()
const;
+
+ /// \brief Convert URI path and parameters to headers.
+ arrow::Result<std::vector<std::pair<std::string, std::string>>> AsHeaders()
const;
Review Comment:
Ok.
I think since we never quite standardized the header-based parameters in the
first place (as I recall, it was just something the JDBC driver happens to do),
if you find it's simpler not to worry about compatibility, then I think that's
OK. We can standardize around cookies/session tokens and assume the server will
track things properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
