pitrou commented on code in PR #36256:
URL: https://github.com/apache/arrow/pull/36256#discussion_r1241839227
##########
cpp/src/arrow/compute/kernels/scalar_if_else_benchmark.cc:
##########
@@ -85,11 +121,25 @@ static void IfElseBench(benchmark::State& state) {
(GetBytesProcessed<BooleanType>::Get(cond) +
GetBytesProcessed<Type>::Get(left) +
GetBytesProcessed<Type>::Get(right)));
+ state.SetItemsProcessed(state.iterations() * (len - offset));
Review Comment:
How about we also make the parameters more readable?
```suggestion
state.SetItemsProcessed(state.iterations() * (len - offset));
state.counters["offset"] = static_cast<double>(offset);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
