mingmwang commented on code in PR #6657:
URL: https://github.com/apache/arrow-datafusion/pull/6657#discussion_r1242059338
##########
datafusion/core/src/physical_plan/aggregates/row_hash.rs:
##########
@@ -496,37 +497,57 @@ impl GroupedHashAggregateStream {
})
.collect::<Result<Vec<_>>>()?;
- for group_idx in groups_with_rows {
- let group_state = &mut self.aggr_state.group_states[*group_idx];
- let mut state_accessor =
- RowAccessor::new_from_layout(self.row_aggr_layout.clone());
- state_accessor.point_to(0,
group_state.aggregation_buffer.as_mut_slice());
- for idx in &group_state.indices {
+ let mut single_value_acc_idx = vec![];
Review Comment:
@alamb
I had combined the RowAccumulators update logic in the `row_hash.rs `and
`bounded_aggregate_stream.rs` and avoided the copy/paste.
There are still some other duplicate coded(not introduced by this PR), I
would prefer to leave it for future PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
