lidavidm commented on code in PR #36192:
URL: https://github.com/apache/arrow/pull/36192#discussion_r1242105046
##########
cpp/src/parquet/file_reader.cc:
##########
@@ -178,13 +179,15 @@ class SerializedRowGroup : public
RowGroupReader::Contents {
std::shared_ptr<::arrow::io::internal::ReadRangeCache>
cached_source,
int64_t source_size, FileMetaData* file_metadata,
int row_group_number, const ReaderProperties& props,
+ const std::unordered_set<int>& prebuffered_column_chunks,
Review Comment:
nit: take this by move and move in the constructor? (so that the caller
chooses whether to copy or not)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
