kou commented on pull request #8908: URL: https://github.com/apache/arrow/pull/8908#issuecomment-747730529
@wesm Sorry, I should have mentioned to you this change. > is that a simplification that's due to a newer version of gRPC or was my workaround just more complicated than it needed to be? Both of them. You put the customization that uses `grpc::protobuf::Message` at 2019-02. gRPC changed to use `grpc::protobuf::MessageLite` from `grpc::protobuf::Message` since 1.22.0 that was released at 2019-06. I didn't confirm but the customization may not be used since gRPC 1.22.0. I don't know why we get build error with gRPC 1.34.0 but doesn't get with gRPC 1.22.0-1.33.2. The main propose of this change is using `grpc::protobuf::MessageLite` not `grpc::protobuf::Message`. The simplification isn't needed. We could re-copy `SerializationTraits` from gRPC but I simplified. Because I think that copying will increase maintenance cost when gRPC changes something. I confirmed that our custom serialization/deserialization codes are called with gRPC 1.34.0 by gdb. I didn't confirm performance because I don't have suitable environment. I also didn't confirm that they are called with gRPC 1.21.4 or older. Sorry. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
