arthurpassos commented on PR #35825: URL: https://github.com/apache/arrow/pull/35825#issuecomment-1608070620
> Thanks a lot for you effort! I do not have any further concerns except the missing test (please correct me if I have missed that). I have added the binarypacked one, but have not added the DeltaLength yet. Currently, there is no `DeltaLength` test in `src/parquet/arrow/arrow_reader_writer_test.cc` for me to use as example. I only found one in `src/parquet/reader_test.cc`, but maybe it's not a good place to put arrow specifics in? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
