jorisvandenbossche commented on PR #36137: URL: https://github.com/apache/arrow/pull/36137#issuecomment-1609666970
Taking a quick look at some of the Python failures: - `test_write_error_deletes_incomplete_file`: I assume the test relied on parquet.write_table to raise an error because of nanosecods being present, and they would get truncated. So either we need to add something else that errors, or we can add `version="2.4"` to keep it using the older parquet version and thus it still errors - `test_timestamp_restore_timezone_nanosecond`: it is creating the expected result with microseconds, but now it comes back as nanoseconds. I think here we want to test explicitly that the timezone is preserved when the resolution changes, so I would also add a `version="2.4"` to keep the test as it was. But you could parametrize the test just above to use different resolutions (ms, us, ns) to cover all of them. - `test_parquet_version_timestamp_differences`: also needs to be updated because the `expected` now contains nanoseconds instead of microseconds (but there are some comments there that are a bit outdated it seems ..) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
