alamb opened a new pull request, #6783: URL: https://github.com/apache/arrow-datafusion/pull/6783
# Which issue does this PR close? Follow on to https://github.com/apache/arrow-datafusion/pull/6654 from @Weijun-H (❤️ ) # Rationale for this change While reviewing https://github.com/apache/arrow-datafusion/pull/6654 and trying to answer @viirya 's question here https://github.com/apache/arrow-datafusion/pull/6654#discussion_r1244324968 # What changes are included in this PR? 1. Rename `date_trunc_single` to `date_trunc_coarse` to better explain what it does 2. Add comments to explain how it works 3. Remove the use of indirection and call the function directly # Are these changes tested? Covered by the (very) nice existing tests added in https://github.com/apache/arrow-datafusion/pull/6654 # Are there any user-facing changes? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
