alamb commented on code in PR #4452:
URL: https://github.com/apache/arrow-rs/pull/4452#discussion_r1244376404
##########
.github/workflows/docs.yml:
##########
@@ -66,20 +66,32 @@ jobs:
- name: Upload artifacts
uses: actions/upload-pages-artifact@v1
with:
+ name: crate-docs
path: target/doc
deploy:
# Only deploy if a push to master
if: github.ref_name == 'master' && github.event_name == 'push'
needs: docs
permissions:
- pages: write # to deploy to Pages
- id-token: write # to verify the deployment originates from an
appropriate source
- environment:
- name: github-pages
- url: ${{ steps.deployment.outputs.page_url }}
+ contents: write
runs-on: ubuntu-latest
steps:
- - name: Deploy to GitHub Pages
- id: deployment
- uses: actions/deploy-pages@v2
+ - uses: actions/checkout@v3
+ - name: Download crate docs
+ uses: actions/download-artifact@v3
+ with:
+ name: crate-docs
+ path: website/build
+ - name: Prepare website
+ run: |
+ tar -xf website/build/artifact.tar -C website/build
+ rm website/build/artifact.tar
+ cp .asf.yaml ./website/build/.asf.yaml
+ - name: Deploy to gh-pages
Review Comment:
> IIUC ASF projects can only run whitelisted actions and
Yes this is my understanding too
> this is an approved action, so it should be fine.
How did you find out it was an approved action? I couldn't seem to find a
definitive list
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
