tustvold commented on code in PR #4389:
URL: https://github.com/apache/arrow-rs/pull/4389#discussion_r1245549252
##########
parquet/src/column/writer/mod.rs:
##########
@@ -668,19 +669,54 @@ impl<'a, E: ColumnValueEncoder> GenericColumnWriter<'a,
E> {
self.column_index_builder.to_invalid();
}
Some(stat) => {
- self.column_index_builder.append(
- null_page,
- stat.min_bytes(),
- stat.max_bytes(),
- self.page_metrics.num_page_nulls as i64,
- );
+ // We only truncate if the data is represented as binary
+ match self.descr.physical_type() {
+ Type::BYTE_ARRAY | Type::FIXED_LEN_BYTE_ARRAY => {
+ self.column_index_builder.append(
+ null_page,
+ self.truncate_min_value(stat.min_bytes()),
+ self.truncate_max_value(stat.max_bytes()),
+ self.page_metrics.num_page_nulls as i64,
+ );
+ }
+ _ => {
+ self.column_index_builder.append(
+ null_page,
+ stat.min_bytes().to_vec(),
+ stat.max_bytes().to_vec(),
+ self.page_metrics.num_page_nulls as i64,
+ );
+ }
+ }
}
}
+
+ // update the offset index
+ self.offset_index_builder
Review Comment:
This change breaks the offset index for entirely null pages
##########
parquet/src/column/writer/mod.rs:
##########
@@ -668,19 +669,54 @@ impl<'a, E: ColumnValueEncoder> GenericColumnWriter<'a,
E> {
self.column_index_builder.to_invalid();
}
Some(stat) => {
- self.column_index_builder.append(
- null_page,
- stat.min_bytes(),
- stat.max_bytes(),
- self.page_metrics.num_page_nulls as i64,
- );
+ // We only truncate if the data is represented as binary
+ match self.descr.physical_type() {
+ Type::BYTE_ARRAY | Type::FIXED_LEN_BYTE_ARRAY => {
+ self.column_index_builder.append(
+ null_page,
+ self.truncate_min_value(stat.min_bytes()),
+ self.truncate_max_value(stat.max_bytes()),
+ self.page_metrics.num_page_nulls as i64,
+ );
+ }
+ _ => {
+ self.column_index_builder.append(
+ null_page,
+ stat.min_bytes().to_vec(),
+ stat.max_bytes().to_vec(),
+ self.page_metrics.num_page_nulls as i64,
+ );
+ }
+ }
}
}
+
+ // update the offset index
+ self.offset_index_builder
Review Comment:
This change breaks the offset index for entirely null pages -
https://github.com/apache/arrow-rs/issues/4459
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
