alamb commented on code in PR #6662: URL: https://github.com/apache/arrow-datafusion/pull/6662#discussion_r1245649783
########## datafusion/core/tests/sqllogictests/test_files/array.slt: ########## @@ -61,18 +61,35 @@ select make_array(make_array()), make_array(make_array(make_array())) ---- [[]] [[[]]] -# TODO issue: https://github.com/apache/arrow-datafusion/issues/6596 -# array_append scalar function #1 -query error DataFusion error: SQL error: ParserError\("Expected an SQL statement, found: caused"\) -caused by -Error during planning: Cannot automatically convert List\(Field \{ name: "item", data_type: Int64, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: \{\} \}\) to List\(Field \{ name: "item", data_type: Null, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: \{\} \}\) +# array scalar function with nulls Review Comment: these examples look much better to me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
