westonpace opened a new pull request, #36368:
URL: https://github.com/apache/arrow/pull/36368

   ### Rationale for this change
   
   When merging two aggregate states we were failing to use the correct 
`no_nulls` field.  This field tells us whether we should return `null` if 
`skip_nulls=False` (if `no_nulls` is false then we return null).
   
   Since we were reading the wrong field we would sometimes emit null even when 
a column didn't actually have any nulls.
   
   ### What changes are included in this PR?
   
   Fixed the bug.
   
   ### Are these changes tested?
   
   Yes, I added a new unit test that reproduced this failure quite reliably.
   
   ### Are there any user-facing changes?
   
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to