alamb commented on code in PR #6792:
URL: https://github.com/apache/arrow-datafusion/pull/6792#discussion_r1245944623
##########
datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs:
##########
@@ -1670,9 +1670,12 @@ mod tests {
fn test_simplify_divide_zero_by_zero() {
// 0 / 0 -> null
let expr = lit(0) / lit(0);
- let expected = lit(ScalarValue::Int32(None));
+ let err = try_simplify(expr).unwrap_err();
- assert_eq!(simplify(expr), expected);
+ assert!(
Review Comment:
This is consistent with postgres 👍
```sql
postgres=# select 0 / 0;
ERROR: division by zero
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
