kou commented on code in PR #36336:
URL: https://github.com/apache/arrow/pull/36336#discussion_r1245991191
##########
cpp/cmake_modules/FindOpenSSLAlt.cmake:
##########
@@ -22,17 +22,24 @@ endif()
if(APPLE AND NOT OPENSSL_ROOT_DIR)
find_program(BREW brew)
if(BREW)
- execute_process(COMMAND ${BREW} --prefix "[email protected]"
- OUTPUT_VARIABLE OPENSSL11_BREW_PREFIX
+ execute_process(COMMAND ${BREW} --prefix "openssl"
Review Comment:
`openssl` is the default OpenSSL formula. In general, it refers the latest
OpenSSL formula (`[email protected]` now).
If `[email protected]` isn't installed, `brew --prefix openssl` is failed.
Then, this process falls back to `[email protected]`, then `[email protected]`. Because
we want to use newer OpenSSL as much as possible.
##########
cpp/cmake_modules/FindOpenSSLAlt.cmake:
##########
@@ -22,17 +22,24 @@ endif()
if(APPLE AND NOT OPENSSL_ROOT_DIR)
find_program(BREW brew)
if(BREW)
- execute_process(COMMAND ${BREW} --prefix "[email protected]"
- OUTPUT_VARIABLE OPENSSL11_BREW_PREFIX
+ execute_process(COMMAND ${BREW} --prefix "openssl"
+ OUTPUT_VARIABLE OPENSSL_BREW_PREFIX
OUTPUT_STRIP_TRAILING_WHITESPACE)
- if(OPENSSL11_BREW_PREFIX)
- set(OPENSSL_ROOT_DIR ${OPENSSL11_BREW_PREFIX})
+ if(OPENSSL_BREW_PREFIX)
+ set(OPENSSL_ROOT_DIR ${OPENSSL_BREW_PREFIX})
else()
- execute_process(COMMAND ${BREW} --prefix "openssl"
- OUTPUT_VARIABLE OPENSSL_BREW_PREFIX
+ execute_process(COMMAND ${BREW} --prefix "[email protected]"
+ OUTPUT_VARIABLE OPENSSL3_BREW_PREFIX
OUTPUT_STRIP_TRAILING_WHITESPACE)
- if(OPENSSL_BREW_PREFIX)
- set(OPENSSL_ROOT_DIR ${OPENSSL_BREW_PREFIX})
+ if(OPENSSL11_BREW_PREFIX)
Review Comment:
Ah, yes. Good catch!
Ah, wait. I should have used `OPENSSL30_...` for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
