jorisvandenbossche commented on code in PR #36314:
URL: https://github.com/apache/arrow/pull/36314#discussion_r1246770844
##########
python/pyarrow/array.pxi:
##########
@@ -1475,6 +1475,22 @@ cdef class Array(_PandasConvertible):
return self.take(indices)
def _to_pandas(self, options, types_mapper=None, **kwargs):
+ pandas_dtype = None
+
+ if types_mapper:
+ pandas_dtype = types_mapper(self.type)
+ elif self.type.id == _Type_EXTENSION:
+ try:
+ pandas_dtype = self.type.to_pandas_dtype()
+ except NotImplementedError:
+ pass
+
+ # Only call __from_arrow__ for Arrow extension types or when explicitly
+ # overridden via types_mapper
+ if hasattr(pandas_dtype, '__from_arrow__'):
+ arr = pandas_dtype.__from_arrow__(self)
+ return pandas_api.series(arr, copy=False)
Review Comment:
`copy=False` should actually also be added to the ChunkedArray version, so
that's fine (would be an improvement)
For `self._name`, that's also already handled inside
`_array_like_to_pandas`, so I think that should work fine for both Array and
ChunkedArray (I assume that for Array, it's just always None)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
