tustvold commented on code in PR #4428:
URL: https://github.com/apache/arrow-rs/pull/4428#discussion_r1247786061
##########
parquet/src/errors.rs:
##########
@@ -44,6 +44,23 @@ pub enum ParquetError {
External(Box<dyn Error + Send + Sync>),
}
+impl PartialEq for ParquetError {
Review Comment:
This is reverted in https://github.com/apache/arrow-rs/pull/4469 as the
semantics of the external variant are not well-defined, and in general we don't
provide PartialEq for error variants
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
