tustvold commented on code in PR #4469:
URL: https://github.com/apache/arrow-rs/pull/4469#discussion_r1247788656
##########
parquet/src/errors.rs:
##########
@@ -44,23 +44,6 @@ pub enum ParquetError {
External(Box<dyn Error + Send + Sync>),
}
-impl PartialEq for ParquetError {
- fn eq(&self, other: &Self) -> bool {
- match (self, other) {
- (Self::General(l0), Self::General(r0)) => l0 == r0,
- (Self::NYI(l0), Self::NYI(r0)) => l0 == r0,
- (Self::EOF(l0), Self::EOF(r0)) => l0 == r0,
- #[cfg(feature = "arrow")]
- (Self::ArrowError(l0), Self::ArrowError(r0)) => l0 == r0,
- (Self::IndexOutOfBound(l0, l1), Self::IndexOutOfBound(r0, r1)) => {
- l0 == r0 && l1 == r1
- }
- (Self::External(l0), Self::External(r0)) => l0.to_string() ==
r0.to_string(),
Review Comment:
If people want string equality, they should explicitly format the error,
however, because `Error` provides downcast machinery implementing equality in
this way is simply incorrect
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
