sgilmore10 opened a new pull request, #36419:
URL: https://github.com/apache/arrow/pull/36419
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's
Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing
Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor
PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes).
Could you open an issue for this pull request on GitHub?
https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the
[Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.)
of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
> **Warning** This PR is dependent on changes in #36366. Once #36366 is
merged, we will rebase on `main` and mark this PR as ready for review.
### Rationale for this change
In the original pull request in which we added the MATLAB
`arrow.type.<Type>Type` classes (e.g. `arrow.type.Float32Type`), we did
implement these classes as proxies. At the time, we weren't sure if it would be
advantageous to implement the type classes as proxies, but now realize it will
be for composite data structures, i.e. `Schema`, `StructArray`, `ListArray`.
### What changes are included in this PR?
1. All classes within the `arrow.type.Type` class hierarchy are implemented
as proxies.
### Are these changes tested?
Yes, we had existing tests for these classes.
### Are there any user-facing changes?
No.
### Future Directions
1. In a followup PR request, we plan on integrating the proxy type classes
and the array classes so that they share the same underlying C++`
arrow::DataType` object. We thought doing so in this change would be too much
code churn.
### Notes
Thank you @kevingurney for the help!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
