felipecrv commented on code in PR #36418:
URL: https://github.com/apache/arrow/pull/36418#discussion_r1248323736
##########
cpp/src/arrow/buffer.h:
##########
@@ -137,6 +139,25 @@ class ARROW_EXPORT Buffer {
/// \return a new Buffer instance
static std::shared_ptr<Buffer> FromString(std::string data);
+ /// \brief Construct an immutable buffer that takes ownership of the contents
+ /// of an std::vector (without copying it).
+ ///
+ /// \param[in] data a string to own
+ /// \return a new Buffer instance
+ template <typename T>
+ static std::shared_ptr<Buffer> FromVector(std::vector<T> vec) {
Review Comment:
I would call this `FromPrimitiveVector` because people frequently mistakenly
assume converting an `std::vector<std::string>` to an Arrow array is an
straightforward operation.
And would it be OK to declare `vec` as `&&` so accidental copies aren't to
easy to create?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
