jackwener commented on code in PR #6824:
URL: https://github.com/apache/arrow-datafusion/pull/6824#discussion_r1249555539
##########
datafusion/core/src/physical_planner.rs:
##########
@@ -958,10 +958,9 @@ impl DefaultPhysicalPlanner {
})
.collect::<Vec<_>>();
let projection =
- logical_plan::Projection::try_new_with_schema(
Review Comment:
here we shouldn't use `join_schema`, because `join_schema` may contain some
column which don't exist in `project schema`
##########
datafusion/expr/src/logical_plan/builder.rs:
##########
@@ -1239,15 +1239,10 @@ pub fn project(
}
}
validate_unique_names("Projections", projected_expr.iter())?;
- let input_schema = DFSchema::new_with_metadata(
- exprlist_to_fields(&projected_expr, &plan)?,
- plan.schema().metadata().clone(),
- )?;
Review Comment:
it already was contained by `try_new_with_schema`, so we can use
`try_new_with_schema` directly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
