mustafasrepo commented on issue #6798:
URL: 
https://github.com/apache/arrow-datafusion/issues/6798#issuecomment-1617600901

   During streaming support for aggregation I tried to reduce duplication 
between `BoundedAggregateStream` and `GroupedHashAggregateStream`. However, it 
reduced performance for some queries as seen in 
[discussion](https://github.com/apache/arrow-datafusion/pull/6034#issuecomment-1520193728)
 
   
   However, I think to benefit both implementations with the following major 
change. It is better to reduce duplication as much as possible even if it 
introduces minor overhead during benchmarks. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to