mapleFU commented on code in PR #36137:
URL: https://github.com/apache/arrow/pull/36137#discussion_r1250547461
##########
cpp/src/parquet/arrow/arrow_schema_test.cc:
##########
@@ -891,7 +890,7 @@ TEST_F(TestConvertArrowSchema, ArrowFields) {
LogicalType::Timestamp(true, LogicalType::TimeUnit::MICROS),
ParquetType::INT64,
-1},
{"timestamp(nanosecond, CET)",
::arrow::timestamp(::arrow::TimeUnit::NANO, "CET"),
- LogicalType::Timestamp(true, LogicalType::TimeUnit::MICROS),
ParquetType::INT64,
+ LogicalType::Timestamp(true, LogicalType::TimeUnit::NANOS),
ParquetType::INT64,
Review Comment:
Should we extract NANOS, and test with both 2_4 and 2_6? Since 2.4 might
still be used for some time
##########
cpp/src/parquet/column_writer_test.cc:
##########
@@ -649,7 +649,7 @@ TYPED_TEST(TestPrimitiveWriter,
DictionaryFallbackVersion1_0) {
}
TYPED_TEST(TestPrimitiveWriter, DictionaryFallbackVersion2_0) {
- this->TestDictionaryFallbackEncoding(ParquetVersion::PARQUET_2_4);
+ this->TestDictionaryFallbackEncoding(ParquetVersion::PARQUET_2_6);
Review Comment:
Emmm should we traverse all 2_0, 2_4, 2_6 ? Or just 2_0 is ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
