viirya commented on issue #6828: URL: https://github.com/apache/arrow-datafusion/issues/6828#issuecomment-1618909637
Read through the diff quickly. > let mul_pow = result_scale - (s2 - s1); I think `result_scale` is min(38, 20 + 38 + 1) = 38? Hmm, for the described case, isn't `mul_pow` equal to 58 (`38 - (0 - 20)`)? As I assume s1, s2 are original scales of lhs, rhs arrays. > The issue is that the coercion logic will scale the right hand side to 5e20 requiring it to also scale the left hand side to 10e40 which will overflow So scaling the left hand side to 10e58 won't overflow? Am I missing any point here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
