kou commented on code in PR #36422:
URL: https://github.com/apache/arrow/pull/36422#discussion_r1251290913
##########
java/dataset/src/test/java/org/apache/arrow/dataset/TextBasedWriteSupport.java:
##########
@@ -24,17 +24,18 @@
import java.net.URISyntaxException;
import java.util.Random;
-public class CsvWriteSupport {
+public class TextBasedWriteSupport {
private final URI uri;
private final Random random = new Random();
- public CsvWriteSupport(File outputFolder) throws URISyntaxException {
- uri = new URI("file", outputFolder.getPath() + "/" + "generated-" +
random.nextLong() + ".csv", null);
+ public TextBasedWriteSupport(File outputFolder, String
jsonOrCsvFileExtension) throws URISyntaxException {
+ uri = new URI("file", outputFolder.getPath() + File.separator +
+ "generated-" + random.nextLong() + jsonOrCsvFileExtension, null);
Review Comment:
```suggestion
public TextBasedWriteSupport(File outputFolder, String fileExtension)
throws URISyntaxException {
uri = new URI("file", outputFolder.getPath() + File.separator +
"generated-" + random.nextLong() + fileExtension, null);
```
##########
java/dataset/src/test/java/org/apache/arrow/dataset/TextBasedWriteSupport.java:
##########
@@ -24,17 +24,18 @@
import java.net.URISyntaxException;
import java.util.Random;
-public class CsvWriteSupport {
+public class TextBasedWriteSupport {
private final URI uri;
private final Random random = new Random();
- public CsvWriteSupport(File outputFolder) throws URISyntaxException {
- uri = new URI("file", outputFolder.getPath() + "/" + "generated-" +
random.nextLong() + ".csv", null);
+ public TextBasedWriteSupport(File outputFolder, String
jsonOrCsvFileExtension) throws URISyntaxException {
+ uri = new URI("file", outputFolder.getPath() + File.separator +
+ "generated-" + random.nextLong() + jsonOrCsvFileExtension, null);
}
- public static CsvWriteSupport writeTempFile(File outputFolder, String...
values)
+ public static TextBasedWriteSupport writeTempFile(File outputFolder, String
jsonOrCsvFileExtension, String... values)
Review Comment:
```suggestion
public static TextBasedWriteSupport writeTempFile(File outputFolder,
String fileExtension, String... values)
```
##########
java/dataset/src/test/java/org/apache/arrow/dataset/TextBasedWriteSupport.java:
##########
@@ -24,17 +24,18 @@
import java.net.URISyntaxException;
import java.util.Random;
-public class CsvWriteSupport {
+public class TextBasedWriteSupport {
private final URI uri;
private final Random random = new Random();
- public CsvWriteSupport(File outputFolder) throws URISyntaxException {
- uri = new URI("file", outputFolder.getPath() + "/" + "generated-" +
random.nextLong() + ".csv", null);
+ public TextBasedWriteSupport(File outputFolder, String
jsonOrCsvFileExtension) throws URISyntaxException {
+ uri = new URI("file", outputFolder.getPath() + File.separator +
+ "generated-" + random.nextLong() + jsonOrCsvFileExtension, null);
}
- public static CsvWriteSupport writeTempFile(File outputFolder, String...
values)
+ public static TextBasedWriteSupport writeTempFile(File outputFolder, String
jsonOrCsvFileExtension, String... values)
throws URISyntaxException, IOException {
- CsvWriteSupport writer = new CsvWriteSupport(outputFolder);
+ TextBasedWriteSupport writer = new TextBasedWriteSupport(outputFolder,
jsonOrCsvFileExtension);
Review Comment:
```suggestion
TextBasedWriteSupport writer = new TextBasedWriteSupport(outputFolder,
fileExtension);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
