mapleFU commented on code in PR #36377:
URL: https://github.com/apache/arrow/pull/36377#discussion_r1251861862
##########
cpp/src/parquet/arrow/writer.cc:
##########
@@ -406,57 +402,7 @@ class FileWriterImpl : public FileWriter {
}
// Max number of rows allowed in a row group.
- const int64_t max_row_group_length =
this->properties().max_row_group_length();
-
- if (row_group_writer_ == nullptr || !row_group_writer_->buffered() ||
- row_group_writer_->num_rows() >= max_row_group_length) {
- RETURN_NOT_OK(NewBufferedRowGroup());
- }
-
- auto WriteBatch = [&](int64_t offset, int64_t size) {
- std::vector<std::unique_ptr<ArrowColumnWriterV2>> writers;
- int column_index_start = 0;
-
- for (int i = 0; i < batch.num_columns(); i++) {
- ChunkedArray chunked_array{batch.column(i)};
- ARROW_ASSIGN_OR_RAISE(
- std::unique_ptr<ArrowColumnWriterV2> writer,
- ArrowColumnWriterV2::Make(chunked_array, offset, size,
schema_manifest_,
- row_group_writer_, column_index_start));
- column_index_start += writer->leaf_count();
- if (arrow_properties_->use_threads()) {
- writers.emplace_back(std::move(writer));
- } else {
- RETURN_NOT_OK(writer->Write(&column_write_context_));
- }
- }
-
- if (arrow_properties_->use_threads()) {
Review Comment:
oops... It's really amazing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
