crepererum commented on PR #6840: URL: https://github.com/apache/arrow-datafusion/pull/6840#issuecomment-1620221775
> This patch doesn't use this [definition](https://substrait.io/extensions/functions_string/#like) as our `Expr::Like` has one more field `escape_char` (but it's not used/supported in the physical plan lol). IIRC I've ran into this issue before as well. I think we should just remove that field and bail out during the SQL->Logical lowering if the SQL parser encounters that (because it seems the logical expr. is modeled after SQL and the physical after whats possible in arrow at the moment). Or we decide that this is a feature we actually want and fix the logical->physical lowering. > Maybe we can combine `Expr::Like` and `Expr::ILike` by adding a field `ignore_case`? Yes please. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
